Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add feature flag for python build #19

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Feat: add feature flag for python build #19

merged 2 commits into from
Dec 4, 2024
+16 −25

Conversation

driemworks
Copy link
Contributor

@driemworks driemworks commented Nov 29, 2024 •
edited
Loading

  • PyO3 was causing the wasm-pack tests to fail
  • this adds a "python" feature flag that must be used to build the PyO3 bindings
  • also updates documentation to indicate this

juangirini
juangirini approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@juangirini juangirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driemworks driemworks merged commit 69da1ef into main Dec 4, 2024
@driemworks driemworks deleted the feat/python branch December 4, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juangirini juangirini juangirini approved these changes

@carloskiron carloskiron Awaiting requested review from carloskiron

@colemanirby colemanirby Awaiting requested review from colemanirby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driemworks @juangirini